Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Solid.Separate Icons #11135

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Add Solid.Separate Icons #11135

merged 2 commits into from
Sep 22, 2020

Conversation

aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Sep 22, 2020 •
edited
Loading

Purpose

DYN-3138: Add Solid.Separate Icons

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang

@aparajit-pratap aparajit-pratap changed the title Add Separate.Solid Icons Add Solid.Separate Icons Sep 22, 2020
@QilongTang QilongTang merged commit a4fee69 into DynamoDS:master Sep 22, 2020
@aparajit-pratap aparajit-pratap deleted the solidIcon branch September 22, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aparajit-pratap @QilongTang