-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style Workspace References consistently #11126
Conversation
Changed the styles of the workspace references extension window to be more consistent with respect to Dynamo. Particularly, buttons that used default WPF button style were switched to now use the same style as in the "Geometry Scaling" window. Also, refresh is no longer a button, to get rid of the undesired hover style, and the image foreground is changed on hover.
Hi @mmisol - Is it possible to make the button a little smaller? It currently takes up significant real-estate. Image shows before and after. The styling looks great beyond that! |
@QilongTang Unfortunately yes. While there is the possibility to create a style based on another, it does not allow to slightly change the template, so I'm creating a new one. It's an easy change anyway. |
That is actually good, I mean still better than the inline style we have right now |
It's looking like this now. What do you guys think? @Amoursol @QilongTang |
@mmisol Can you test in German and some language with long strings? If they can be displayed correctly, I am good with this change |
@QilongTang I'm pretty sure I went back to the same size and spacing as before. Could you do the comparison again @Amoursol ? |
Looks good to me now @mmisol ! |
Purpose
Changed the styles of the workspace references extension window to be
more consistent with respect to Dynamo. Particularly, buttons that used
default WPF button style were switched to now use the same style as in
the "Geometry Scaling" window. Also, refresh is no longer a button, to
get rid of the undesired hover style, and the image foreground is
changed on hover.
Here is how it looks like now:
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@QilongTang @aparajit-pratap
FYIs
@Amoursol