Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Workspace References consistently #11126

Merged
merged 2 commits into from
Sep 20, 2020

Conversation

mmisol
Copy link
Collaborator

@mmisol mmisol commented Sep 17, 2020

Purpose

Changed the styles of the workspace references extension window to be
more consistent with respect to Dynamo. Particularly, buttons that used
default WPF button style were switched to now use the same style as in
the "Geometry Scaling" window. Also, refresh is no longer a button, to
get rid of the undesired hover style, and the image foreground is
changed on hover.

Here is how it looks like now:

workspace_references

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang @aparajit-pratap

FYIs

@Amoursol

Changed the styles of the workspace references extension window to be
more consistent with respect to Dynamo. Particularly, buttons that used
default WPF button style were switched to now use the same style as in
the "Geometry Scaling" window. Also, refresh is no longer a button, to
get rid of the undesired hover style, and the image foreground is
changed on hover.
@Amoursol
Copy link
Contributor

Amoursol commented Sep 18, 2020

Hi @mmisol - Is it possible to make the button a little smaller? It currently takes up significant real-estate. Image shows before and after.

image

The styling looks great beyond that!

@QilongTang
Copy link
Contributor

QilongTang commented Sep 18, 2020

@mmisol About @Amoursol 's request, does that require a new template for button other than STextButton?

@mmisol
Copy link
Collaborator Author

mmisol commented Sep 18, 2020

@QilongTang Unfortunately yes. While there is the possibility to create a style based on another, it does not allow to slightly change the template, so I'm creating a new one. It's an easy change anyway.

@QilongTang
Copy link
Contributor

@QilongTang Unfortunately yes. While there is the possibility to create a style based on another, it does not allow to slightly change the template, so I'm creating a new one. It's an easy change anyway.

That is actually good, I mean still better than the inline style we have right now

@mmisol
Copy link
Collaborator Author

mmisol commented Sep 18, 2020

It's looking like this now. What do you guys think? @Amoursol @QilongTang

smaller_button

@QilongTang
Copy link
Contributor

@mmisol Can you test in German and some language with long strings? If they can be displayed correctly, I am good with this change

@mmisol
Copy link
Collaborator Author

mmisol commented Sep 18, 2020

@QilongTang I'm pretty sure I went back to the same size and spacing as before. Could you do the comparison again @Amoursol ?

@Amoursol
Copy link
Contributor

@QilongTang I'm pretty sure I went back to the same size and spacing as before. Could you do the comparison again @Amoursol ?

Looks good to me now @mmisol !
image

@QilongTang QilongTang merged commit cac5a7f into DynamoDS:master Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants