Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify unbounded ids in binary expressions #11125

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

mmisol
Copy link
Collaborator

@mmisol mmisol commented Sep 17, 2020

Purpose

Unbounded identifiers were not recognized in some binary expressions.
This was a parser issue, which was failing to set the line and column
properly for some expressions. The problem was detected when negative
floats or characters (not strings) were used in the right hand side.

The issue was also fixed for declarative blocks for completeness but
it should not affect variable creation for unbounded identifiers.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@aparajit-pratap @QilongTang

FYIs

@DynamoDS/dynamo

Unbounded identifiers were not recognized in some binary expressions.
This was a parser issue, which was failing to set the line and column
properly for some expressions. The problem was detected when negative
floats or characters (not strings) were used in the right hand side.

The issue was also fixed for declarative blocks for completeness but
it should not affect variable creation for unbounded identifiers.
@mmisol mmisol merged commit aeeebce into DynamoDS:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants