Allow extension panel to grow without bounds #11102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the 500 units bound on the extension panel width. The panel can be enlarged as much as needed, while respecting the minimum size of the canvas panel, which remains as 200 units. Also, the extension panel size is remembered during a session. Serves both as a nice to have and a avoids a splitter bug. Also, the workspace references extension is fixed so that it adapts to bigger sizes. It didn't stretch beyond 600 units.
|
Workspace references extension looks like this when stretched:
|
|
@mmisol Can you install TuneUp and provide a screen shot as well? I suspect changes in the other repo might be needed as well. |
|
@QilongTang TuneUp seems to stretch just fine. Do you know what's up with those failures? They don't seem related to my changes and locally the tests pass just fine...
|
|
@mmisol I noticed some random failures in @aparajit-pratap 's PR as well, thinking we can ignore those for now |
QilongTang
reviewed
Sep 9, 2020
QilongTang
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Removes the 500 units bound on the extension panel width. The panel can
be enlarged as much as needed, while respecting the minimum size of the
canvas panel, which remains as 200 units.
Also, the extension panel size is remembered during a session. Serves
both as a nice to have and a avoids a splitter bug.
Also, the workspace references extension is fixed so that it adapts to
bigger sizes. It didn't stretch beyond 600 units.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang @reddyashish
FYIs
@DynamoDS/dynamo