Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icons for new PolyCurve.ByThickeningCurveNormal node #11101

Merged
merged 2 commits into from
Sep 10, 2020

Conversation

aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Sep 9, 2020

Purpose

This PR sets the icon for the old PolyCurve.ByThickeningCurve node on the new one as the old one is deprecated.

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang
Copy link
Contributor

Test failure: ViewExtensionLibraryTests.DynamoLibraryItemsTests.VerifyIconsForLibraryItems

@QilongTang
Copy link
Contributor

DynamoCoreWpfTests.JSONSerializationTests.NewCustomNodeSaveAndLoadPt2 This test look irrelevant but failing, can you verify locally?

@aparajit-pratap
Copy link
Contributor Author

@QilongTang the test passes for me locally but it is supposed to run right after NewCustomNodeSaveAndLoadPt1.

@QilongTang
Copy link
Contributor

@QilongTang QilongTang merged commit 50a68ee into DynamoDS:master Sep 10, 2020
@aparajit-pratap aparajit-pratap deleted the updateIcons branch September 10, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants