Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pan/orbit state icon #11092

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Update pan/orbit state icon #11092

merged 2 commits into from
Sep 2, 2020

Conversation

mmisol
Copy link
Collaborator

@mmisol mmisol commented Sep 2, 2020

Purpose

Fixes issues related to the state of the pan icon not reflecting the
actual current state.

There were two problems preventing this from updating.

Some actions did not seem to trigger a property change on IsPlanning
and IsOrbiting at the BackgroundPreviewViewModel. There are properties
with the same name in the local view model that get updated more
consistently.

Some actions were triggering property change events in the wrong place.
These were moved to the right place.

While there were no reported issues with IsOrbiting, this property
should behave in the same way, so the same changes were applied.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang @zeusongit

FYIs

@DynamoDS/dynamo

Fixes issues related to the state of the pan icon not reflecting the
actual current state.

There were two problems preventing this from updating.

Some actions did not seem to trigger a property change on IsPlanning
and IsOrbiting at the BackgroundPreviewViewModel. There are properties
with the same name in the local view model that get updated more
consistently.

Some actions were triggering property change events in the wrong place.
These were moved to the right place.

While there were no reported issues with IsOrbiting, this property
should behave in the same way, so the same changes were applied.
Copy link
Contributor

@zeusongit zeusongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but maybe add some comments for some context like the once you removed in Escape() and ToggleOrbit().

@mmisol
Copy link
Collaborator Author

mmisol commented Sep 2, 2020

@zeusongit I didn't actually remove those comments. Just moved them to the RefreshState() function which is now called from those other places.

@zeusongit
Copy link
Contributor

Ah.. ok, got it.

@mmisol mmisol merged commit 0002403 into DynamoDS:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants