Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "keepalive" flag to CLI to enable loaded extensions to control process lifetime #11090

Merged
merged 3 commits into from
Sep 4, 2020

Conversation

Dewb
Copy link
Contributor

@Dewb Dewb commented Sep 2, 2020

Purpose

This PR adds a -k/--keepalive flag to the CLI. This will launch the engine and wait for additional commands to be queued from loaded extensions; the process will not exit until a loaded extension shuts down the model.

This adds a new boolean field to the public class StartupUtils.CommandLineArguments.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • n/a Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • n/a This PR modifies some build requirements and the readme is updated

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copy link
Contributor

@sm6srw sm6srw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any logic in the test failure. Looks like a sporadic failure to me. Other than that: LGTM!

Copy link
Contributor

@aparajit-pratap aparajit-pratap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dewb could you give some context to this change? I may have missed the discussion if it took place elsewhere.

@Dewb Dewb merged commit 78ec538 into DynamoDS:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants