Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom node small icon load in library #11063

Merged
merged 2 commits into from
Aug 27, 2020

Conversation

mmisol
Copy link
Collaborator

@mmisol mmisol commented Aug 27, 2020

Purpose

Icons for packages custom nodes (dyf files) were not loaded in the
library. This was due to a bug that created a wrong url, which used a
default name, instead of the custom node id.

Fixes #10669

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@reddyashish @aparajit-pratap

FYIs

@DynamoDS/dynamo

Icons for packages custom nodes (dyf files) were not loaded in the
library. This was due to a bug that created a wrong url, which used a
default name, instead of the custom node id.
@mmisol
Copy link
Collaborator Author

mmisol commented Aug 27, 2020

Before:
customnode_icon_repro

After:
customnode_icon_fixed

Copy link
Contributor

@aparajit-pratap aparajit-pratap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmisol looks good but I think there are few regressions, probably because you've added a new package and the tests counting the total number of packages need to be updated.

Question about whether:

  1. icons can be added for zero touch nodes by following the steps in the wiki.
  2. the wiki for adding icons to custom nodes is accurate.

@mmisol
Copy link
Collaborator Author

mmisol commented Aug 27, 2020

@aparajit-pratap Will check those tests.

For the example I'm showing here I followed those steps so I'd say it's accurate, only that the bug was preventing it from working.

I did not check ZT nodes because the reported issue was not related to them. I can also do that but should not be related to this PR. As you can see in the code this is a custom node specific error condition.

@mmisol mmisol merged commit e2640b3 into DynamoDS:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package icons do not show up in library
2 participants