Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery Updates to include Python3 info #11046

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Gallery Updates to include Python3 info #11046

merged 2 commits into from
Aug 24, 2020

Conversation

QilongTang
Copy link
Contributor

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

FYIs

@Amoursol @DynamoDS/dynamo

@QilongTang
Copy link
Contributor Author

Got sign off from @Amoursol , merging and will cherrypick soon

@QilongTang QilongTang merged commit a829558 into master Aug 24, 2020
@QilongTang QilongTang deleted the GalleryUpdates branch August 24, 2020 19:26
@aparajit-pratap
Copy link
Contributor

@QilongTang I'm assuming you have tested the updated gallery in D4R locally?

@QilongTang
Copy link
Contributor Author

@aparajit-pratap Yes, the attached picture in this PR is from testing

QilongTang added a commit that referenced this pull request Aug 24, 2020
* GalleryUpdates

* resize the image to be 1250 * 833
QilongTang added a commit that referenced this pull request Aug 24, 2020
* Update learn more message (#11036)

* Update learn more message

* Add titile

* Updates of wording (#11045)

* Gallery Updates to include Python3 info (#11046)

* GalleryUpdates

* resize the image to be 1250 * 833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants