Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick: Fix layout issue in Python editor #11044

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Cherry pick: Fix layout issue in Python editor #11044

merged 1 commit into from
Aug 24, 2020

Conversation

mmisol
Copy link
Collaborator

@mmisol mmisol commented Aug 24, 2020

Purpose

Bring #11042 into 2.8.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@mmisol
Fix layout issue hiding Python editor buttons (DynamoDS#11042)
79873a3 
This fixes an issue that partially hid the "More info" button in the
Python editor window when the UI was shown in German language. In that
case "Run" would display as "Ausführen" which pushed the content to the
right causing the "More info" button to be trimmed because it fell out
of the boundaries of its container.

The issue is fixed by removing the parent grid, resulting in a simpler
and more flexible layout.
@mmisol mmisol changed the title Fix layout issue hiding Python editor buttons (#11042) Cherry pick: Fix layout issue in Python editor Aug 24, 2020
@mmisol mmisol merged commit 44889e6 into DynamoDS:RC2.8.0_master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mmisol