fix isolate selected regression, and longstanding issue with selection highlight. #11037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regen images disable update image define remove unneccesary sorting
| float3 nudge = normalize(input.n) * 0.0001; | ||
| inputp = float4(input.p.x + nudge.x, input.p.y + nudge.y, input.p.z + nudge.z, input.p.w); | ||
| // Nudge the vertex out slightly along its normal a tiny bit. | ||
| inputp = float4(inputp.x + nudge.x, inputp.y + nudge.y, inputp.z + nudge.z, inputp.w); |
There was a problem hiding this comment.
In this case if there are say 2 overlapping geometries, won't they both be nudged outwards? If so, what will this achieve?
|
@DynamoDS/dynamo Team decided to merge for Dynamo 2.8 and cherry-pick for now. |
QilongTang
pushed a commit
that referenced
this pull request
Aug 24, 2020
…n highlight. (#11037) * this works, but ideally it would be done in the shader to avoid this sorting * update shader to make selected geometry more prominent than vertColored geo new tests * move camera closer regen images disable update image define remove unneccesary sorting * fix copy paste error
QilongTang
added a commit
that referenced
this pull request
Aug 24, 2020
…n highlight. (#11037) (#11041) * this works, but ideally it would be done in the shader to avoid this sorting * update shader to make selected geometry more prominent than vertColored geo new tests * move camera closer regen images disable update image define remove unneccesary sorting * fix copy paste error Co-authored-by: Michael Kirschner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In 2.7 there was a regression with isolateSelection, but I also found there was a long standing issue with overlapping geometry in some cases not highlighting correctly even during normal selection.
this pr does the following:
inside the dynamo mesh vertex shader - selected geometry is moved along the normal of each vertex by
.01- this is large enough to prevent z-fighting even when zoomed outed until the geometry is no longer visible..0001.0101visualization tests are added for two spheres in exactly the same location in isolation mode and regular selection mode.
The reason that we need an additional increment for selected geometry is because I found most mesh geometry we generate has white vertex colors so all verts are moved slightly... essentially nothing special was being done for selected geometry. These colors were applied in LibG many years ago, and I don't think it is worth the risk to modify that at this point.
For those who are curious I found that the reason this worked in 2.6 for isolated geometry, which was that after every interaction we would resort all geometry in the scene so that the selected geometry was rendered last... it's great to be able to skip this given that this sorting could be slow if there was a lot of geometry.
Declarations
Check these if you believe they are true
*.resxfiles