add no changes state to diff viewer #11001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Amoursol if you guys are happy with this approach, some feedback on the text would be much appropriated. |
|
I love the style! Still, I think we could make it clearer that they should click "accept" , so that the engine is changed. How does something like |
mmisol
reviewed
Aug 14, 2020
| @@ -145,6 +145,9 @@ There will be a time of transition where both versions of Python node will work | |||
| <data name="IronPythonNotificationShortMessage" xml:space="preserve"> | |||
| <value>This graph currently contains nodes that are using the old IronPython2 (Python 2) engine which will be deprecated in later versions. A new CPython3 (Python 3) has been implemented and is accessible inside the Python editor.</value> | |||
| </data> | |||
| <data name="MigrationAssisantNoChangesStateMessage" xml:space="preserve"> | |||
There was a problem hiding this comment.
Typo Assisant => Assistant
|
hah, we just talked about this - chiming in to say this looks great. |
|
LGTM! |
mmisol
approved these changes
Aug 17, 2020
mmisol
pushed a commit
to mmisol/Dynamo
that referenced
this pull request
Aug 17, 2020
* add has changes state to diff viewer * update text + change engine on accept * typo
8 tasks
mmisol
added a commit
that referenced
this pull request
Aug 17, 2020
* add has changes state to diff viewer * update text + change engine on accept * typo Co-authored-by: Sylvester Knudsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When the Migration Assistant is used on code that is already Python 3 compatible the diff viewer will still show the code. This can lead to confusion as it looks like the Migration Assistant isnt working/doing anything.
This PR adds a
No Changesstate to the Diff viewer which will let the user know if no changes are needed.Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mmisol
FYIs
@mjkkirschner
@QilongTang
@Amoursol