Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration assistant legal messages #10965

Merged
merged 87 commits into from
Aug 6, 2020
Merged

Migration assistant legal messages #10965

merged 87 commits into from
Aug 6, 2020

Conversation

SHKnudsen
Copy link
Contributor

Purpose

This PR adds a legal message to the Migration Assistant when the user wants to accept the changes proposed. the warning message has the option to Do not show again which will store a text file with a timestamp and the name of the machine in AppData\Local\Dynamo.

PythonMigrationWarningMessages

Disable warning dialog file

PythonMigrationWarningMessages

Migration Assistant warning dialog

PythonMigrationWarningMessagesDialog

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

@mmisol

FYIs

@mjkkirschner
@Amoursol
@radumg

SHKnudsen added 30 commits July 3, 2020 08:19
@SHKnudsen
T1.1 Code Migration (#4)
9e29adc 
* add ScriptMigrator

* Add visual difference viewer

* Update PythonMigrationViewExtension.cs

* Add tooltip description to migration assistant

* updates

* comment updates

* comment updates
@SHKnudsen
Update PythonMigrationViewExtension.csproj
0fbd696
@SHKnudsen
T1.2 accept/reject code changes (#5)
c0ab018 
* add ScriptMigrator

* Add visual difference viewer

* Added methods for updating the ScriptEditors with the migrated code

* Update PythonMigrationViewExtension.cs

* Add tooltip description to migration assistant

* updates

* comment updates

* comment updates

* Update ScriptEditorWindow.xaml.cs

* Update PythonMigrationViewExtension.csproj

* Update PythonMigrationViewExtension.csproj

* comment updates

* Revert "comment updates"

This reverts commit 2d2332a.

* comment updates

* Update PythonMigrationAssistantViewModel.cs

* comment updates 2
@SHKnudsen
update engine version when migrating code
1684a49
@SHKnudsen
Merge remote-tracking branch 'upstream/master' into T1.1-CodeMigration
e52d617
@SHKnudsen
extension and test updates
b7fe228
@SHKnudsen
Merge branch 'T1.1-CodeMigration' into T1.2-AcceptReject-CodeChanges
f168751
@SHKnudsen
T1.3 save python2 backup file on migration (#6)
831946e 
* add ScriptMigrator

* Add visual difference viewer

* Added methods for updating the ScriptEditors with the migrated code

* Update PythonMigrationViewExtension.cs

* add mechanisme to save Python 2 backup

* Add tooltip description to migration assistant

* updates

* comment updates

* comment updates

* Update ScriptEditorWindow.xaml.cs

* Update PythonMigrationViewExtension.csproj

* Update PythonMigrationViewExtension.csproj

* comment updates

* Revert "comment updates"

This reverts commit 2d2332a.

* comment updates

* Update PythonMigrationAssistantViewModel.cs

* comment updates 2

* small clean ups

* Update PythonMigrationAssistantViewModel.cs
@SHKnudsen
Merge branch 'T1.3-SavePython2BackupFile' of https://github.com/SHKnu…
7229746 
…dsen/Dynamo into T1.3-SavePython2BackupFile
@SHKnudsen
add 2to3 icon
6caa0db
@SHKnudsen
Merge branch 'T1.1-CodeMigration' into T1.2-AcceptReject-CodeChanges
451a980
@SHKnudsen
Merge branch 'T1.2-AcceptReject-CodeChanges' into T1.3-SavePython2Bac…
9542bf8 
…kupFile
@SHKnudsen
comment updates
8a70055
@SHKnudsen
GraphPythonDependencies changes
f9ab1d5
@SHKnudsen
Merge branch 'master' into T1.1-CodeMigration
8d2f36b
@SHKnudsen
make event internal
f3edb0f
@SHKnudsen
fix build failure
3f264dd
@SHKnudsen
update license files, MigrationAssitantClicked event and PythonMigrat…
c34f729 
…ionAssistantTests
@SHKnudsen
Merge branch 'master' into T1.1-CodeMigration
fdf7fe6
@SHKnudsen
Merge branch 'T1.1-CodeMigration' into T1.2-AcceptReject-CodeChanges
904dee5
@SHKnudsen
clean up
d497eb4
@SHKnudsen
Merge branch 'T1.2-AcceptReject-CodeChanges' into T1.3-SavePython2Bac…
33f5aad 
…kupFile
@SHKnudsen
clean up
235851d
@SHKnudsen
update licence files
cfb0a98
@SHKnudsen
Merge branch 'T1.1-CodeMigration' into T1.2-AcceptReject-CodeChanges
6912267
@SHKnudsen
Merge branch 'T1.2-AcceptReject-CodeChanges' into T1.3-SavePython2Bac…
acbe079 
…kupFile
@SHKnudsen
Merge remote-tracking branch 'upstream/master' into T1.2-AcceptReject…
9bec448 
…-CodeChanges
@SHKnudsen
make MigrateCode internal
f06d7a2
@SHKnudsen
comments update
088e008
@SHKnudsen
unsubscribe from ScriptEditorWindow closed
303c644
radumg and others added 19 commits July 29, 2020 22:19
@radumg
parametrise the differ window initial width
0e54cac
@radumg
resolve conflict between the 2 python migration viewmodels
d260338
@radumg
Merge branch 'T1.5-VisualDifferenceViewer-With-text-wrap' of https://…
4c97566 
…github.com/SHKnudsen/Dynamo into pr/10932
@radumg
adjust initial window widths to keep text same wrapping
1bceea7 
also allow for slightly larger vertical height for Before/After label as it was hard to spot
@radumg
update diff colours to Dynamo pallette
425a7bd
@radumg
update splitter colour in side diff layout to be black
12ee797
@radumg
upgrade the inline display mode to also show fragments
75a60bc
@SHKnudsen
update sizing of diff viewer
400749e
@SHKnudsen
update warning dialog
8a17330
@SHKnudsen
Merge branch 'T1.5-VisualDifferenceViewer-With-text-wrap' into migrat…
d42e226 
…ion-assistant-warning
@SHKnudsen
migration assistant warning save setting
b73907a
@SHKnudsen
Update PythonMigrationAssistantViewModel.cs
81bba10
@SHKnudsen
add dynamo version to file path
d5b4150
@SHKnudsen
comment updates
f349ddb
@SHKnudsen
only create warning dismiss file if accepted
b315f6d
@SHKnudsen
comments updates 2
a406b96
@SHKnudsen
Merge branch 'master' into migration-assistant-warning
f4ce0d3
@SHKnudsen
Update PythonMigrationViewExtension.csproj
d67e2b0
@SHKnudsen
Update PythonMigrationAssistantViewModel.cs
2bd5a56
mmisol
mmisol reviewed Aug 5, 2020
View reviewed changes
Copy link
Collaborator

@mmisol mmisol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An additional comment. It's unclear to me what the dialog's initial position is. I saw it in the gif but also happened to me while running. Should it be centered on top of the diff viewer?

src/PythonMigrationViewExtension/Controls/MigrationAssistantWarning.xaml.cs Outdated Show resolved Hide resolved
src/PythonMigrationViewExtension/Controls/MigrationAssistantWarning.xaml.cs Outdated Show resolved Hide resolved
src/PythonMigrationViewExtension/Controls/MigrationAssistantWarning.xaml.cs Outdated Show resolved Hide resolved
src/PythonMigrationViewExtension/Controls/MigrationAssistantWarning.xaml Outdated Show resolved Hide resolved
src/PythonMigrationViewExtension/MigrationAssistant/PythonMigrationAssistantViewModel.cs Show resolved Hide resolved
src/PythonMigrationViewExtension/MigrationAssistant/PythonMigrationAssistantViewModel.cs Outdated Show resolved Hide resolved
@SHKnudsen
Copy link
Contributor Author

@mmisol addressed the comments, should be good to go.

mmisol
mmisol reviewed Aug 6, 2020
View reviewed changes
Copy link
Collaborator

@mmisol mmisol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SHKnudsen . Just noticed some minor issues and some texts that should be externalized as resources.

src/PythonMigrationViewExtension/Controls/MigrationAssistantDisclaimer.xaml.cs Outdated Show resolved Hide resolved
src/PythonMigrationViewExtension/Controls/MigrationAssistantDisclaimer.xaml.cs Outdated Show resolved Hide resolved
src/PythonMigrationViewExtension/Controls/MigrationAssistantDisclaimer.xaml Outdated Show resolved Hide resolved
mmisol
mmisol approved these changes Aug 6, 2020
View reviewed changes
Copy link
Collaborator

@mmisol mmisol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mmisol mmisol merged commit 8de5fc6 into DynamoDS:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amoursol Amoursol Amoursol left review comments

@radumg radumg radumg left review comments

@mjkkirschner mjkkirschner mjkkirschner left review comments

@mmisol mmisol mmisol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SHKnudsen @mjkkirschner @mmisol @radumg @Amoursol