Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DYN-2827] Added Show/Hide spaces and tabs option for Python script editor. #10948

Merged
merged 9 commits into from
Aug 10, 2020

Conversation

zeusongit
Copy link
Contributor

Purpose

[DYN-2827]
Add a global setting option Show Python Editor Whitespace Characters.
Show/Hide spaces and tabs in python script editor
Preserve setting in preferences.
Add Tests

spacesntabs

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • [] All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@DynamoDS/dynamo

Copy link
Member

@mjkkirschner mjkkirschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can make the textEditor options on DynamoViewModel internal.

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mjkkirschner mjkkirschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it still functions after your latest changes - LGTM

@zeusongit
Copy link
Contributor Author

I am able to access the members after making them internal, and the script editor works fine.
Will merge.
Thank you for the review.

@QilongTang
Copy link
Contributor

@zeusongit Did you forgot to merge or waiting for the PR checks?

@zeusongit
Copy link
Contributor Author

zeusongit commented Aug 10, 2020

@QilongTang Was waiting for the self serve, which just completed, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants