-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DYN-2827] Added Show/Hide spaces and tabs option for Python script editor. #10948
Conversation
src/Libraries/PythonNodeModelsWpf/Resources/ICSharpCode.PythonBinding.Resources.Python.xshd
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Core/Converters/DynamoTextOptions.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Core/Converters/DynamoTextOptions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can make the textEditor options on DynamoViewModel internal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it still functions after your latest changes - LGTM
I am able to access the members after making them internal, and the script editor works fine. |
@zeusongit Did you forgot to merge or waiting for the PR checks? |
@QilongTang Was waiting for the self serve, which just completed, merging. |
Purpose
[DYN-2827]
Add a global setting option
Show Python Editor Whitespace Characters
.Show/Hide spaces and tabs in python script editor
Preserve setting in preferences.
Add Tests
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@DynamoDS/dynamo