-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easily install missing IronPython extension package #10869
Conversation
src/WorkspaceDependencyViewExtension/WorkspaceDependencyViewExtension.cs
Outdated
Show resolved
Hide resolved
src/WorkspaceDependencyViewExtension/WorkspaceDependencyViewExtension.csproj
Outdated
Show resolved
Hide resolved
src/WorkspaceDependencyViewExtension/WorkspaceDependencyView.xaml.cs
Outdated
Show resolved
Hide resolved
src/WorkspaceDependencyViewExtension/WorkspaceDependencyView.xaml.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions related to this PR and the future. Probably something we should answer as a team.
What should be the strategy for releasing future versions of the Iron Python engine package? Should 2.7.9 be the version here and whenever 3.0.0 is released we deprecate the previous version of the package in PM (if that's possible)?
We talked about removing the migration functionality in Python Epic 8. I think we should make sure to do that at a time it is no longer relevant, which would have to be some time after we deprecate the 2.7.9 version of the Iron Python engine package. I'm not sure if it should be enough to infer some info about usage from Package Manager, by tracking downloads, or if we should use analytics to cover cases where users have already installed the package and are just using it.
src/WorkspaceDependencyViewExtension/WorkspaceDependencyViewExtension.cs
Outdated
Show resolved
Hide resolved
src/WorkspaceDependencyViewExtension/WorkspaceDependencyViewExtension.cs
Outdated
Show resolved
Hide resolved
src/PythonMigrationViewExtension/PythonMigrationViewExtension.cs
Outdated
Show resolved
Hide resolved
@@ -12,6 +12,9 @@ namespace Dynamo.PythonMigration | |||
public class GraphPythonDependencies | |||
{ | |||
private ViewLoadedParams ViewLoaded { get; set; } | |||
internal static readonly string PythonPackage = "DSIronPython_Test"; | |||
internal static readonly Version PythonPackageVersion = new Version(1, 0, 7); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These will be updated once the IronPython extension is published to PM prod.
@mmisol, as discussed I think the strategy is to add new packages for new engine versions and make them available in the PM in the future. |
Purpose
Easily install missing IronPython extension package.
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of