Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tooltips in Python Editor #10820

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Update Tooltips in Python Editor #10820

merged 1 commit into from
Jun 29, 2020

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jun 29, 2020

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Update tooltips in Python editor.
image
image
image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

</data>
<data name="PythonScriptEditorRunButtonTooltip" xml:space="preserve">
<value>Run Python node with current code in editor.</value>
<value>Run Python node with current code in editor and save it.</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, this reads backwards to me, - what do you think about - Save current code and run it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

@mjkkirschner
Copy link
Member

mjkkirschner commented Jun 29, 2020

cherry picking to 2.7 seems fine, though localization will need time to localize these updates.

@QilongTang
Copy link
Contributor Author

@mjkkirschner Done. Let me know

@QilongTang QilongTang merged commit 49c12e0 into master Jun 29, 2020
@QilongTang QilongTang deleted the UpdateTooltips branch June 29, 2020 20:38
@QilongTang QilongTang restored the UpdateTooltips branch June 29, 2020 20:42
@QilongTang
Copy link
Contributor Author

@mjkkirschner Oops, too fast.. Let me push my local changes..

QilongTang added a commit that referenced this pull request Jun 29, 2020
QilongTang added a commit that referenced this pull request Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants