Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to nuspec files to work with 4.8 .Net Framework #10732

Merged
merged 7 commits into from
Jun 8, 2020

Conversation

alfredo-pozo
Copy link
Contributor

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

This PR is to update the generated Nuget packages of Dynamo to 4.8 .Net Framework and is related to the JIRA task https://jira.autodesk.com/browse/DYN-2685

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

@QilongTang
@mjkkirschner

alfredo-pozo and others added 6 commits April 16, 2020 14:35
Update forked master branch
Update forked master branch
Update forked master branch
Update master forked repository
Update forked master branch
…cated elements and warnings when the nuget packages are created
</dependencies>
</metadata>
<files>
<file src="DSIronPython.dll" target="lib\net48" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjkkirschner Do you recall why we include IronPython in nuget? Do we need to include CPython now?

@mjkkirschner
Copy link
Member

mjkkirschner commented Jun 4, 2020 via email

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QilongTang
Copy link
Contributor

QilongTang commented Jun 8, 2020

@alfredo-pozo @mjkkirschner Merging this, the self serve error does not look related

@QilongTang QilongTang merged commit 631f469 into DynamoDS:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants