-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to nuspec files to work with 4.8 .Net Framework #10732
Conversation
Update forked master branch
Update forked master branch
Update forked master branch
Update master forked repository
Update forked master branch
…cated elements and warnings when the nuget packages are created
tools/NuGet/template-artifactory/DynamoVisualProgramming.DynamoCoreRuntime.nuspec
Show resolved
Hide resolved
</dependencies> | ||
</metadata> | ||
<files> | ||
<file src="DSIronPython.dll" target="lib\net48" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjkkirschner Do you recall why we include IronPython in nuget? Do we need to include CPython now?
Yeah was wondering this as well - let’s not add more here and instead shrink the Api when we can
… On Jun 4, 2020, at 8:45 AM, Aaron (Qilong) ***@***.***> wrote:
@QilongTang commented on this pull request.
In tools/NuGet/template-nuget/DynamoVisualProgramming.Core.nuspec:
> + 7) ProtoCore.dll
+ 8) DesignScriptBuiltin.dll
+ 9) VMDataBridge.dll</description>
+ <summary>This package contains the core assemblies for Dynamo.</summary>
+ <copyright>Copyright Autodesk 2019</copyright>
+ <dependencies>
+ <group targetFramework=".NETFramework4.8">
+ <dependency id="Prism" version="4.1"/>
+ <dependency id="NUnit" version="2.6.3"/>
+ <dependency id="DynamoVisualProgramming.ZeroTouchLibrary" version="$Version$"/>
+ <dependency id="Newtonsoft.Json" version="8.0.3"/>
+ </group>
+ </dependencies>
+ </metadata>
+ <files>
+ <file src="DSIronPython.dll" target="lib\net48" />
@mjkkirschner Do you recall why we include IronPython in nuget? Do we need to include CPython now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@alfredo-pozo @mjkkirschner Merging this, the self serve error does not look related |
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
This PR is to update the generated Nuget packages of Dynamo to 4.8 .Net Framework and is related to the JIRA task https://jira.autodesk.com/browse/DYN-2685
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@QilongTang
@mjkkirschner