-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AGD-1437 Can not preload a package with an apostrophe in its the folder path. #10685
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,7 +105,7 @@ public void TestLoadDllFileFailure() | |
|
||
[Test] | ||
[Category("UnitTests")] | ||
public void TestLoadDllFileSuccess() | ||
public void TestLoadDllFileSuccessWithLibrarySearchPathsResultionToFindDLL() | ||
{ | ||
LibraryLoaded = false; | ||
|
||
|
@@ -121,6 +121,32 @@ public void TestLoadDllFileSuccess() | |
Assert.IsTrue(LibraryLoaded); | ||
} | ||
|
||
[Test] | ||
[Category("UnitTests")] | ||
public void TestLoadDllFileAtPathSuccess() | ||
{ | ||
LibraryLoaded = false; | ||
|
||
string libraryPath = Path.Combine(TestDirectory, "pkgs", "Package", "bin", @"Package.dll"); | ||
|
||
libraryServices.ImportLibrary(libraryPath); | ||
|
||
Assert.IsTrue(LibraryLoaded); | ||
} | ||
|
||
[Test] | ||
[Category("UnitTests")] | ||
public void TestLoadDllFileWithApostropheInPathSuccess() | ||
{ | ||
LibraryLoaded = false; | ||
|
||
string libraryPath = Path.Combine(TestDirectory, "pkgs", "Pack'age", "bin", @"Package.dll"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @QilongTang This test fails with out the formatting fix There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @saintentropy maybe I misunderstand the issue, how would There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry now I get your question @QilongTang. The path here gets modified here https://github.com/DynamoDS/Dynamo/blob/master/src/Engine/ProtoCore/Utils/CompilerUtils.cs#L258 in The return value of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Above is one example of the of the call to |
||
|
||
libraryServices.ImportLibrary(libraryPath); | ||
|
||
Assert.IsTrue(LibraryLoaded); | ||
} | ||
|
||
[Test] | ||
[Category("UnitTests")] | ||
public void TestLibraryAcrossSessions() | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"license":"","file_hash":null,"name":"Package","version":"1.0.0","description":"original package","group":"","keywords":null,"dependencies":[],"contents":"","engine_version":"2.1.0.7840","engine":"dynamo","engine_metadata":"","site_url":"","repository_url":"","contains_binaries":true,"node_libraries":["Package, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null"]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand it correctly this is replacing
\'
with'
, but how would the test case reflect this fix? Maybe I missed something?