Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update greg - this changes the name of zipped temp package files #10564

Merged
merged 2 commits into from
Apr 14, 2020

Conversation

mjkkirschner
Copy link
Member

Purpose

update greg (package manager client) nuget package to avoid zipping bug caused by running the tests in parallel to avoid multiple processes trying to access the same zip file.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

@QilongTang
Copy link
Contributor

LGTM. However notice it takes sometime for the newly published nugets to appear in the downloadable list. I suggest wait a bit to merge this.

Copy link
Contributor

@zeusongit zeusongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjkkirschner
Copy link
Member Author

@QilongTang yes, I also want to see if this causes any regressions.

@mjkkirschner
Copy link
Member Author

😒 - some properties got reversed in order in the csproj files, will fix it.

@alfredo-pozo
Copy link
Contributor

LGTM

@mjkkirschner mjkkirschner merged commit cf06e69 into DynamoDS:master Apr 14, 2020
@mjkkirschner mjkkirschner deleted the updategreg134 branch April 14, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants