Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node to convert string to Title Case #10554

Merged
merged 4 commits into from
Apr 9, 2020

Conversation

mmisol
Copy link
Collaborator

@mmisol mmisol commented Apr 8, 2020

Purpose

Adds a node that allows to convert a string to title case, i.e. "stay at home" becomes "Stay At Home".
This is based on the changes in #10470 by @chuong9x, making the following changes:

  • Code is moved to CoreNodes.String. String.String was not really used so the project was deleted.
  • Several other unused projects were deleted.
  • Added unit tests for the new node.
  • Added icons for the new node.
  • Added the node to the library.

Node in library
Screen Shot 2020-04-08 at 5 46 13 PM

Node in action
Screen Shot 2020-04-08 at 5 47 33 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

@mjkkirschner @QilongTang

FYIs

@chuong9x @Amoursol

@mjkkirschner
Copy link
Member

@mmisol nice cleanup, coreNodeUI folder always confused me.... Since you're in here already... can you also delete DynamoPackagesUI? I think thats another project that is not built.

@QilongTang
Copy link
Contributor

LGTM

@QilongTang
Copy link
Contributor

@mmisol Did we close the original PR?

@mmisol mmisol mentioned this pull request Apr 9, 2020
@mmisol
Copy link
Collaborator Author

mmisol commented Apr 9, 2020

@QilongTang I just did. Thanks for the reminder

@QilongTang QilongTang added the LGTM Looks good to me label Apr 9, 2020
@mmisol mmisol merged commit 8801e30 into DynamoDS:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants