DYN-4228 Convert StrongConnectComponent to use List vs Dictionary input type #10355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rough perf comparison for a the compilation step for a sample graph of 320 nodes |
| @@ -337,18 +337,17 @@ private bool CyclicDependencyTest(ProtoCore.AssociativeGraph.GraphNode node, ref | |||
| return true; | |||
| } | |||
|
|
|||
| var indexMap = new Dictionary<GraphNode, int>(); | |||
| var lowlinkMap = new Dictionary<GraphNode, int>(); | |||
| var indexList = new int[codeBlock.instrStream.dependencyGraph.GraphList.Count]; | |||
There was a problem hiding this comment.
Is this the actual place where we're getting the perf improvement; since you are pre-allocating the size of the array in this case rather than initializing an empty dictionary that needs to be expanded every other time values are added to it?
saintentropy
changed the title
saintentropy
changed the title
saintentropy
changed the title
aparajit-pratap
approved these changes
Apr 25, 2022
aparajit-pratap
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/DYN-4228
The purpose of this PR is to remove a performance bottleneck that affect graphs with larger node quantities. In the graph compilation phase, cyclic dependencies in the graph logic are detected for error and warning purpose. Part of this detection process creates a numerous Dictionary collections which incurred significant time and memory allocation. This PR refactors the
StrongConnectComponentmethod to utilize existing data found in the GraphNode object (specifically thedependencyGraphListIDproperty) vs the creation of new Map data structure for a lookup key.Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner @aparajit-pratap
FYIs
@reddyashish