Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick agd1300 #10221

Merged
merged 3 commits into from
Dec 13, 2019

Conversation

saintentropy
Copy link
Contributor

Purpose

This is a cherry pick of the common directory package implementation to the 2.5 release.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

@QilongTang

FYIs

@mjkkirschner

… definition directory alternative (DynamoDS#10208)

* Add common package folder location similar to common definitions directory to PathManager

* Initalize common package directory

* Add a list of root directories to verify certificates and check those before adding the package

* fix null value check

* Update comments

* Modify package and package loader to only check libraries defined in pkg.json manifest

* Check view extension for valid signed certificate if path matches root to check

* Upate extension loader to validate extension have valid certificate if they are found in directories requiring verification

* Rename package property for to RequiresSignedEntryPoints

* Fix bugs in package loader signed check

* Revise view extension / extension loading logic to avoid ext deff pointing to dll outside of check dir

* Comments

* Package PR comments

* Extension loading pr comments

* View extension pr comments

* On more comment

* Refactor .Net assembly cetificate verication to DynamoCrypto

* Consume validate method from DyanmoCrypto

* Add comments

* Move cert verification method to DynamoUtilities Class

* Add new CertificateVerification class to DynamoUtilities

* Update comments

* Extract package error messages to resource files

* Add comments and change RequiresSignedEntryPoints to internal

* Add test Cases for signed packages

(cherry picked from commit 717bb16)
* Add untitlity test

(cherry picked from commit 2fcd3b5)

* Fix lib tests

(cherry picked from commit 7ae1302)

* Add check to package property

(cherry picked from commit 8e1bc3c)

* Mark test for failure

(cherry picked from commit 32d7a2d)
* Update the signed package file to uniqure namespace

(cherry picked from commit 0005f38)

* Add comment including the zt node

(cherry picked from commit 16c28de)

* Update comment

(cherry picked from commit 75346ca)
@mjkkirschner mjkkirschner merged commit 3da9f10 into DynamoDS:RC2.5.0_master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants