Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syswinint to 3.x (align with Revit) #10170

Merged
merged 4 commits into from
Nov 27, 2019

Conversation

mjkkirschner
Copy link
Member

Purpose

Aligns to latest blend sdk version of system.windows.interactivity - this is the same version popular packages and Revit itself ships:

related:
#10162
#10163

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@mjkkirschner mjkkirschner changed the title Update syswinint Update syswinint to 3.x (align with Revit) Nov 26, 2019
@aparajit-pratap aparajit-pratap added the LGTM Looks good to me label Nov 26, 2019
@mjkkirschner mjkkirschner removed the WIP label Nov 26, 2019
@mjkkirschner
Copy link
Member Author

@QilongTang is this good to merge or do you want to look at other solutions first?

@QilongTang
Copy link
Contributor

@mjkkirschner LGTM

@mjkkirschner
Copy link
Member Author

acad does not seem to include this dll. merging.

@mjkkirschner mjkkirschner merged commit 1ad0321 into DynamoDS:master Nov 27, 2019
@mjkkirschner mjkkirschner mentioned this pull request Jun 1, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants