Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect path in sample hint #10159

Merged
merged 1 commit into from
Nov 25, 2019
Merged

incorrect path in sample hint #10159

merged 1 commit into from
Nov 25, 2019

Conversation

ZiyunShang
Copy link
Contributor

Purpose

Update notes where described location for DynamoSample.rvt file
Jira Issue: https://jira.autodesk.com/browse/REVIT-153320

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

@aparajit-pratap @QilongTang

FYIs

@AndyDu1985

@mjkkirschner
Copy link
Member

looks good to me @ZiyunShang - any objections @QilongTang ?

@QilongTang QilongTang added the LGTM Looks good to me label Nov 25, 2019
@QilongTang QilongTang merged commit defba1b into DynamoDS:master Nov 25, 2019
@ZiyunShang ZiyunShang deleted the UpgradeDynamoRevitSampleFiles branch December 10, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
LGTM Looks good to me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZiyunShang @mjkkirschner @QilongTang