Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #10146 - remove libg223, add support for asm226 #10152

Merged
merged 3 commits into from
Nov 20, 2019
Merged

Cherry-pick #10146 - remove libg223, add support for asm226 #10152

merged 3 commits into from
Nov 20, 2019

Conversation

aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Nov 20, 2019 •
edited
Loading

Purpose

Cherry-pick #10146

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

FYIs

@DynamoDS/dynamo

@mjkkirschner
Copy link
Member

@aparajit-pratap looks good.

@aparajit-pratap aparajit-pratap merged commit 245b0dd into DynamoDS:RC2.5.0_master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aparajit-pratap @mjkkirschner