Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated transform_all.bat #10109

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Conversation

zeusongit
Copy link
Contributor

Edited transform_all.bat to work with vs2019, utilizing vswhere.exe utility.

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

https://jira.autodesk.com/browse/DYN-2152

AssemblySharedInfo.tt file was not being updated with the latest build no., as the paths for vs were not defined.
Now, by using vswhere tool, vs path is provided irrespective of the version used to build the project.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@DynamoDS/dynamo

FYIs

edited to work with vs2019
@QilongTang
Copy link
Contributor

LGTM

@QilongTang QilongTang added the LGTM Looks good to me label Nov 5, 2019
@mjkkirschner
Copy link
Member

@zeusongit @QilongTang @aparajit-pratap do you think the build should fail if this transform fails? Right now it does not.

@mjkkirschner mjkkirschner self-requested a review November 5, 2019 20:28
Copy link
Member

@mjkkirschner mjkkirschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeusongit this looks good, I just have two questions.

@QilongTang
Copy link
Contributor

I dont think the build should fail for everyday user.. 3rd party dev should not worry about this I think. @mjkkirschner @aparajit-pratap What do you think?

@QilongTang
Copy link
Contributor

I am going to merge this, at the same time uninstalling VS2017 locally on my machine to test this

@QilongTang QilongTang merged commit b1145a5 into DynamoDS:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants