Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove xml to markdown flow and infrastructure #10077

Merged
merged 2 commits into from
Nov 5, 2019

Conversation

mjkkirschner
Copy link
Member

Purpose

Remove appveyor publish
Remove gitsubmodules
Remove xmlToMarkdownProject (debatable if we want to remove this as part of a cleanup)

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@QilongTang
@smangarole
@zeusongit

@QilongTang
Copy link
Contributor

@mjkkirschner I am ok removing XmlDocToMarkdown, I feel like we should redirect to other pages for Dynamo API if we do this cleanly though..

@mjkkirschner
Copy link
Member Author

@QilongTang I will redirect to fuget for now - but removing this code will not bring the site down - so we can do that later if we wish.

@QilongTang
Copy link
Contributor

@mjkkirschner shall we?

@mjkkirschner
Copy link
Member Author

yes, lets see if anything breaks.

@mjkkirschner mjkkirschner merged commit c68936d into DynamoDS:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants