Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration docs #10003

Merged
merged 4 commits into from
Sep 23, 2019
Merged

Integration docs #10003

merged 4 commits into from
Sep 23, 2019

Conversation

mjkkirschner
Copy link
Member

Purpose

adds integration docs (in progress) to the docs folder of the dynamo repo

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@QilongTang
@aparajit-pratap
@ColinDayOrg

FYI:
@angelowang

@mjkkirschner
Copy link
Member Author

Screen Shot 2019-09-23 at 1 48 54 PM

if you click view file, you should see the rendered markdown.

@QilongTang
Copy link
Contributor

LGTM

@QilongTang QilongTang added the LGTM Looks good to me label Sep 23, 2019
@mjkkirschner
Copy link
Member Author

merging this -please continue to leave comments on the PR - I will address them.

@mjkkirschner mjkkirschner merged commit c062264 into DynamoDS:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants