Skip to content

Commit

Permalink
DYN-7222 DefaultValues Locale
Browse files Browse the repository at this point in the history
Due that there was a hard-coded string in the code the DocumentationBrowser was not showing the Input Default Values when Dynamo is in a different language than English.
So I added the hard-coded string as a Resource
  • Loading branch information
RobertGlobant20 committed Aug 20, 2024
1 parent 23b596c commit f9dbd37
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ private static string GetDefaultValueFromDescription(string element)
var stringArr = element.Split(new string[] { "\r\n", "\r", "\n" }, StringSplitOptions.None);
foreach (var line in stringArr)
{
if (line.ToLowerInvariant().Contains("default value"))
if (line.ToLowerInvariant().Contains(Resources.InputDefaultValue))
{
return line.Remove(0, 16);
}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,9 @@
<value>Zoom out</value>
<comment>Image Control ToolTip</comment>
</data>
<data name="InputDefaultValue" xml:space="preserve">
<value>default value</value>
</data>
<data name="InsertedGroupSubTitle" xml:space="preserve">
<value>Inserted Dynamo graph</value>
</data>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -216,4 +216,7 @@
<data name="ToastFileNotFoundLocationNotificationText" xml:space="preserve">
<value>Example file from {0} could not be found</value>
</data>
<data name="InputDefaultValue" xml:space="preserve">
<value>default value</value>
</data>
</root>

0 comments on commit f9dbd37

Please sign in to comment.