DYN-6350 add request timeout for notification service (#14564)

* add request timeout for notification service * refactor: implement an auto-property instead of a field for notifications request timeOut * set notification request timeOut of 10000ms * refactor: move notifications request timeOut as a constant within Dynamo Configuration --------- Co-authored-by: reddyashish <[email protected]>
DynamoDS · Nov 10, 2023 · 9df196d · 9df196d
1 parent bc265ce
commit 9df196d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/DynamoCore/Configuration/Configurations.cs b/src/DynamoCore/Configuration/Configurations.cs
@@ -429,5 +429,12 @@ internal static Dictionary<Units, double> SupportedUnits
         }
 
         #endregion
+
+        #region Notifications Constants
+        /// <summary>
+        /// Request timeOut for notifications service
+        /// </summary>
+        public const int NotificationsDefaultTimeOut = 10000;
+        #endregion
     }
 }
diff --git a/src/Notifications/NotificationCenterController.cs b/src/Notifications/NotificationCenterController.cs
@@ -17,6 +17,7 @@
 using Newtonsoft.Json;
 using Microsoft.Web.WebView2.Wpf;
 using Dynamo.Utilities;
+using Dynamo.Configuration;
 
 namespace Dynamo.Notifications
 {
@@ -164,6 +165,7 @@ private void RequestNotifications()
             var uri = DynamoUtilities.PathHelper.GetServiceBackendAddress(this, "notificationAddress");
             HttpWebRequest request = (HttpWebRequest)WebRequest.Create(uri);
             request.AutomaticDecompression = DecompressionMethods.GZip | DecompressionMethods.Deflate;
+            request.Timeout = Configurations.NotificationsDefaultTimeOut;
 
             using (HttpWebResponse response = (HttpWebResponse)request.GetResponse())
             using (Stream stream = response.GetResponseStream())