Skip to content

Commit

Permalink
target shader model 4 to avoid crash when user does not have GPU. (#1…
Browse files Browse the repository at this point in the history
…0497)

* special render packages should render with materials
add test
update shader

* fix comment

* update comments

* lower intensity of directional light
add new image comp tests
add new color dyn files that are easy to modify on the fly
add first set of reference images

* add new tests
add ref images
all pass local

* comment

* drop to shader model 4 to avoid crash on WARP devices
  • Loading branch information
mjkkirschner authored Mar 25, 2020
1 parent d77d640 commit 9d4bdff
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
Binary file not shown.
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ REM -/I ./../ include
REM - /Fo output binary path
REM file to compile Default.fx

fxc /Vi /Od /Zi /T vs_5_0 /I ./helix_shader_defs/COMMON /Fo ..\compiledShaders\vsDynamoMesh vsDynamoMesh.hlsl
fxc /Vi /Od /Zi /T ps_5_0 /I ./helix_shader_defs/COMMON /Fo ..\compiledShaders\psDynamoMesh psDynamoMesh.hlsl
fxc /Vi /Od /Zi /T vs_4_0 /I ./helix_shader_defs/COMMON /Fo ..\compiledShaders\vsDynamoMesh vsDynamoMesh.hlsl
fxc /Vi /Od /Zi /T ps_4_0 /I ./helix_shader_defs/COMMON /Fo ..\compiledShaders\psDynamoMesh psDynamoMesh.hlsl

This comment has been minimized.

Copy link
@aparajit-pratap

aparajit-pratap Mar 27, 2020

Contributor

@mjkkirschner does it make sense to revert this now that there is no interpolation going on?

This comment has been minimized.

Copy link
@mjkkirschner

mjkkirschner Mar 27, 2020

Author Member

no, we can keep this for max compatibility with older graphics cards, we don't use any of the features of shader model 5 (4 supports everything we need) -

and helix 2.11 still crashes when using shader model 5 in software rendering mode anyway - they fixed it in 2.12 - which is not out yet, but even when it's fixed, no reason to require shader model 5 if we use none of its features.

popd
pause

0 comments on commit 9d4bdff

Please sign in to comment.