DYN-5787-LuceneNET-InCanvasSearch Code Review

Added several comments and removed unused fields.
DynamoDS · May 22, 2023 · 9af2277 · 9af2277
1 parent fb5ea58
commit 9af2277
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/DynamoCore/Models/DynamoModel.cs b/src/DynamoCore/Models/DynamoModel.cs
@@ -1627,7 +1627,7 @@ private void InitializeNodeLibrary()
 
             CustomNodeManager.AddUninitializedCustomNodesInPath(pathManager.CommonDefinitions, IsTestMode);
 
-            //Initialize searcher
+            //Initialize searcher, if the applyAllDeletes is true all buffered deletes on documents will be applied (made visible) in the returned reader
             dirReader = writer.GetReader(applyAllDeletes: true);
             IndexSearcher searcher = new IndexSearcher(dirReader);
 
@@ -3254,6 +3254,7 @@ private NodeModelSearchElement AddNodeTypeToSearch(TypeLoadData typeLoadData)
         /// <returns></returns>
         private Document InitializeIndexDocument()
         {
+            //TODO: all this harcoded string values should be moved to a different class.
             var fullCategory = new TextField("FullCategoryName", "", Field.Store.YES);
             var name = new TextField("Name", "", Field.Store.YES);
             var description = new TextField("Description", "", Field.Store.YES);

diff --git a/src/DynamoCore/Search/NodeSearchModel.cs b/src/DynamoCore/Search/NodeSearchModel.cs
@@ -17,10 +17,11 @@ namespace Dynamo.Search
     /// </summary>
     public class NodeSearchModel : SearchLibrary<NodeSearchElement, NodeModel>
     {
-        internal XmlDocument document;
 
+        //Holds the instance for the IndexSearcher
         internal IndexSearcher Searcher;
 
+        ////Used in DynamoModel for creating the StandardAnalyzer
         internal Analyzer Analyzer;
 
         /// <summary>