Don't throw if a package has dlls but no node libraries. (#13626)

DynamoDS · Dec 9, 2022 · 940ce05 · 940ce05
1 parent 0c48518
commit 940ce05
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/DynamoPackages/PackageLoader.cs b/src/DynamoPackages/PackageLoader.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
@@ -692,15 +692,14 @@ private Version CheckAndGetPackageVersion(string version, string name, string di
         /// </summary>
         /// <param name="packageDirectoryPath">path to package location</param>
         /// <param name="discoveredPkg">package object to check</param>
-        private static void CheckPackageNodeLibraryCertificates(string packageDirectoryPath, Package discoveredPkg)
+        private void CheckPackageNodeLibraryCertificates(string packageDirectoryPath, Package discoveredPkg)
         {
             var dllfiles = new System.IO.DirectoryInfo(discoveredPkg.BinaryDirectory).EnumerateFiles("*.dll");
             if (discoveredPkg.Header.node_libraries.Count() == 0 && dllfiles.Count() != 0)
             {
-                throw new LibraryLoadFailedException(packageDirectoryPath,
-                    String.Format(
-                        Resources.InvalidPackageNoNodeLibrariesDefinedInPackageJson,
-                        discoveredPkg.Name, discoveredPkg.RootDirectory));
+                Log(String.Format(
+                    String.Format(Resources.InvalidPackageNoNodeLibrariesDefinedInPackageJson,
+                    discoveredPkg.Name, discoveredPkg.RootDirectory)));
             }
 
             foreach (var nodeLibraryAssembly in discoveredPkg.Header.node_libraries)