harden discovery of codeCompletionProvider. (#10858)

* try catch * review comments
DynamoDS · Jul 7, 2020 · 8cd74d2 · 8cd74d2
1 parent a898bd0
commit 8cd74d2
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/src/Libraries/PythonNodeModelsWpf/SharedCompletionProvider.cs b/src/Libraries/PythonNodeModelsWpf/SharedCompletionProvider.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Linq;
+using System.Reflection;
 using Autodesk.DesignScript.Interfaces;
 using Dynamo.Logging;
 using ICSharpCode.AvalonEdit.CodeCompletion;
@@ -31,15 +32,22 @@ internal SharedCompletionProvider(PythonEngineVersion version ,string dynamoCore
             }
         }
 
-        internal static IExternalCodeCompletionProviderCore FindMatchingCodeCompletionCore 
+        internal static IExternalCodeCompletionProviderCore FindMatchingCodeCompletionCore
             (string versionName, ILogger logger = null)
         {
             try
             {
                 var completionType = typeof(IExternalCodeCompletionProviderCore);
                 var loadedCodeCompletionTypes = AppDomain.CurrentDomain.GetAssemblies()
-                    .SelectMany(s => s.GetTypes())
-                    .Where(p => completionType.IsAssignableFrom(p) && !p.IsInterface);
+                    .SelectMany(s => {
+                        try {
+                            return s.GetTypes();
+                        }
+                        catch (ReflectionTypeLoadException)
+                        {
+                            return new Type[0];
+                        }
+                    }).Where(p => completionType.IsAssignableFrom(p) && !p.IsInterface).ToList();
                 //instantiate them - so we can check which is a match using their match method
                 foreach (var type in loadedCodeCompletionTypes)
                 {