Skip to content

Commit

Permalink
Add coverage for docking (#11262)
Browse files Browse the repository at this point in the history
  • Loading branch information
QilongTang authored Nov 19, 2020
1 parent 9363746 commit 05d461e
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,9 @@ internal void UndockExtensionTab(object sender, RoutedEventArgs e)
{
var tabName = (sender as Button).DataContext.ToString();
UndockExtension(tabName);
Logging.Analytics.TrackEvent(
Actions.Undock,
Categories.ViewExtensionOperations, tabName);
}

/// <summary>
Expand Down Expand Up @@ -413,6 +416,9 @@ private void ExtensionWindow_Closed(object sender, EventArgs e)
if (ext.DockRequested)
{
AddExtensionTabItem((IViewExtension)ext.Tag, content);
Logging.Analytics.TrackEvent(
Actions.Dock,
Categories.ViewExtensionOperations, extName);
}
else
{
Expand Down
10 changes: 10 additions & 0 deletions src/NodeServices/IAnalyticsClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,16 @@ public enum Actions
/// Load event, such as extensions loaded
/// </summary>
Load,

/// <summary>
/// Dock event, such as docking view extension
/// </summary>
Dock,

/// <summary>
/// Undock event, such as undocking view extension
/// </summary>
Undock,
}

/// <summary>
Expand Down

0 comments on commit 05d461e

Please sign in to comment.