Update the signed package file to uniqure namespace

DynamoDS · Dec 12, 2019 · 0005f38 · 0005f38
1 parent de2a7e6
commit 0005f38
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/test/Libraries/DynamoUtilitiesTests/CertificateVerificationTests.cs b/test/Libraries/DynamoUtilitiesTests/CertificateVerificationTests.cs
@@ -18,7 +18,7 @@ public void CheckAssemblyForValidCertificateTest()
         {
             var executingDirectory = Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location);
             var directory = new DirectoryInfo(executingDirectory);
-            var testFilePath = Path.Combine(directory.Parent.Parent.Parent.FullName, "test", "pkgs_signed", "Signed Package", "bin", "Package.dll");
+            var testFilePath = Path.Combine(directory.Parent.Parent.Parent.FullName, "test", "pkgs_signed", "Signed Package", "bin", "SignedPackage.dll");
 
             Assert.IsTrue(File.Exists(testFilePath));
 

diff --git a/test/Libraries/PackageManagerTests/PackageLoaderTests.cs b/test/Libraries/PackageManagerTests/PackageLoaderTests.cs
@@ -537,8 +537,6 @@ public void ScanPackageDirectoryWithCheckingCertificatesEnabledWillNotLoadPackag
         }
 
         [Test]
-        //Todo need to add a new signed package file with unique name space
-        [Category("Failure")]
         public void ScanPackageDirectoryWithCheckingCertificatesEnabledWillLoadPackageWithValidCertificate()
         {
             var loader = new PackageLoader(new[] { PackagesDirectory }, new[] { PackagesDirectorySigned });
@@ -557,11 +555,11 @@ public void ScanPackageDirectoryWithCheckingCertificatesEnabledWillLoadPackageWi
 
             // Verify that package resolved successfully
             var libs = CurrentDynamoModel.LibraryServices.ImportedLibraries.ToList();
-            Assert.IsTrue(libs.Contains(Path.Combine(PackagesDirectorySigned, "Signed Package", "bin", "Package.dll")));
+            Assert.IsTrue(libs.Contains(Path.Combine(PackagesDirectorySigned, "Signed Package", "bin", "SignedPackage.dll")));
 
             // Verify that the package are imported successfully
             var entries = CurrentDynamoModel.SearchModel.SearchEntries.ToList();
-            Assert.IsTrue(entries.Any(x => x.FullName == "Package.Package.Package.Hello"));
+            Assert.IsTrue(entries.Any(x => x.FullName == "SignedPackage.SignedPackage.SignedPackage.Hello"));
         }
 
         [Test]

diff --git a/...kgs_signed/Signed Package/bin/Package.dll → ...gned/Signed Package/bin/SignedPackage.dll b/...kgs_signed/Signed Package/bin/Package.dll → ...gned/Signed Package/bin/SignedPackage.dll
diff --git a/test/pkgs_signed/Signed Package/pkg.json b/test/pkgs_signed/Signed Package/pkg.json
@@ -1 +1 @@
-{"license":"","file_hash":null,"name":"Package","version":"1.0.0","description":"original package","group":"","keywords":null,"dependencies":[],"contents":"","engine_version":"2.1.0.7840","engine":"dynamo","engine_metadata":"","site_url":"","repository_url":"","contains_binaries":true,"node_libraries":["Package, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null"]}
+{"license":"","file_hash":null,"name":"Package","version":"1.0.0","description":"original package","group":"","keywords":null,"dependencies":[],"contents":"","engine_version":"2.1.0.7840","engine":"dynamo","engine_metadata":"","site_url":"","repository_url":"","contains_binaries":true,"node_libraries":["SignedPackage, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null"]}
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		{"license":"","file_hash":null,"name":"Package","version":"1.0.0","description":"original package","group":"","keywords":null,"dependencies":[],"contents":"","engine_version":"2.1.0.7840","engine":"dynamo","engine_metadata":"","site_url":"","repository_url":"","contains_binaries":true,"node_libraries":["Package, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null"]}
		{"license":"","file_hash":null,"name":"Package","version":"1.0.0","description":"original package","group":"","keywords":null,"dependencies":[],"contents":"","engine_version":"2.1.0.7840","engine":"dynamo","engine_metadata":"","site_url":"","repository_url":"","contains_binaries":true,"node_libraries":["SignedPackage, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null"]}