Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Setting Page Template File Input Won't let you type more than one character at a time. #52

Open
2 tasks done
barnes7td opened this issue Jul 13, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@barnes7td
Copy link

Issue Searching

  • I have searched for similar issues that are open.
  • I have searched for similar issues that are closed.

OtherIssues

None

Description

In the Settings menu every time you type a character in the Template File text input, the input box loses focus, only allowing the user to type one character at a time.

Reproduction steps

Go to the Luhman Settings inside of the Obsidian Settings. Add or remove a character in the text input for Template File.

Expected Result

I expect that I could keep typing until I type the full path to the template file.

Actual Result

I type one character, the input box loses focus, and I have to click back on the text input in order to type again.

Version

1.2.0 (Current Version)

Relevent log output

No response

Screenshots

No response

Other Notes

I am a developer. The reason this happens is because this.display() is called on ever onChange event of the text input, effectively removing the focus of the text input.

I have a fix worked out. I want to contribute. Is there a protocol for a PR to this repo?

@barnes7td barnes7td added the bug Something isn't working label Jul 13, 2023
@barnes7td barnes7td changed the title [BUG] Title [BUG] Setting Page Template File Input Won't let you type more than one character at a time. Jul 13, 2023
barnes7td added a commit to barnes7td/luhman-obsidian-plugin that referenced this issue Jul 13, 2023
agctute added a commit to agctute/luhman-obsidian-plugin that referenced this issue Jul 15, 2023
@agctute
Copy link

agctute commented Jul 20, 2023

@barnes7td Your commit also works to fix this bug, I made a "less is more" alternative in the above PR. Maybe @Eforen can choose?

@barnes7td
Copy link
Author

@agctute The problem with not calling this.display() in your version, means the config screen won't update (hide/show options dependent on the on the contents of this input field). That's why I did the more involved solution.

@Eforen
Copy link
Collaborator

Eforen commented Oct 2, 2023

what do you mean will not allow you to type more then one character at a time?

@agctute
Copy link

agctute commented Oct 4, 2023

Every time a character is input into the text box, the box behaves as if Esc is pressed immediately after. You have to click on the text box again in order to input the next character, in which case the problem repeats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants