Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Podfiles to work with cocoapods 1.x #272 #273

Open
wants to merge 1 commit into
base: feature-dev
Choose a base branch
from

Conversation

abillingsley
Copy link
Collaborator

Proposed Change

Cocoapods 1.x changes the format of the podfile slightly this updates the podfiles used in the SignalR-ObjC project to conform to cocoapods 1.x.

Types of changes

What types of changes does your code introduce to SignalR-ObjC? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

I am not sure the impacts on environments that may still depend on prior versions of cocoapods. It is possible that the xcodeproj => project change would be breaking if other podfiles are using the xcodeproj property

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@joeldart
Copy link
Member

joeldart commented Jul 6, 2016

Planning for backwards compat:
we would still have 2.0.2 for those using cocoapods 0.39.0 and can add that to the documentation as the path forward there. We'll have to update some of our build infrastructure to get this working in CI (requirement before landing).

@abillingsley
Copy link
Collaborator Author

@joeldart note I did not make any changes to the podspec (I don't think that is a requirement for #272) since it appears @richardgroves is either trying to run the examples or debug in the SignalR-ObjC code base directly.

You are correct that the build server will need to be updated to cocoapods 1.x which could make for additional work on the other projects that leverage old versions of cocopods but SignalR-ObjC should be able to be integrated into projects using any reasonable version of cocoapods 0.3x or 1.x.

@richardgroves can checkout feature-cocoapods1.x to run the examples etc in a cocoapods 1.x environment

@richardgroves
Copy link
Contributor

Thanks @abillingsley - that all works well for me on Cocoapods 1.0.1 now. You are correct in that I was building the main project and trying to run the examples, rather than just integrating it into another project (that works fine on 1.0.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants