Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Socialite driver typings + callable typings #103

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

juliangums
Copy link
Contributor

No description provided.

@juliangums juliangums mentioned this pull request Jun 21, 2024
@bert-w
Copy link
Contributor

bert-w commented Jun 21, 2024

@juliangums I made some additional changes, since apparently it is also possible for Socialite drivers to return other kinds of response like strings even. The typing of Laravel\Socialite\Two\AbstractProvider::redirect() is in that sense wrong since its docblock says @return \Illuminate\Http\RedirectResponse (which is not always the case).

The other changes in the typings allow the end-user to do some other stuff with the callbacks the plugin provides.

@bert-w bert-w changed the title Make RedirectResponse wider Improve Socialite driver typings + callable typings Jun 21, 2024
@bert-w bert-w merged commit 7729ee5 into DutchCodingCompany:main Jun 21, 2024
11 checks passed
@juliangums
Copy link
Contributor Author

Looks good. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants