Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a functional API #8

Merged
merged 17 commits into from
Apr 6, 2021
Merged

Implement a functional API #8

merged 17 commits into from
Apr 6, 2021

Conversation

DudeNr33
Copy link
Owner

@DudeNr33 DudeNr33 commented Apr 6, 2021

This pull requests:

@codecov-io
Copy link

codecov-io commented Apr 6, 2021

Codecov Report

Merging #8 (f460d46) into master (8afc8b4) will decrease coverage by 1.79%.
The diff coverage is 94.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   96.66%   94.87%   -1.80%     
==========================================
  Files           1        5       +4     
  Lines          60      117      +57     
  Branches        6       12       +6     
==========================================
+ Hits           58      111      +53     
- Misses          1        5       +4     
  Partials        1        1              
Impacted Files Coverage Δ
src/pyinstaller_versionfile/__main__.py 81.81% <81.81%> (ø)
src/pyinstaller_versionfile/writer.py 92.85% <92.85%> (ø)
src/pyinstaller_versionfile/metadata.py 96.36% <96.36%> (ø)
src/pyinstaller_versionfile/__init__.py 100.00% <100.00%> (ø)
src/pyinstaller_versionfile/exceptions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8afc8b4...f460d46. Read the comment docs.

@DudeNr33 DudeNr33 merged commit f63ed46 into master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take a dictionary instead of a file Improve error handling
2 participants