Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No error when inserting a Version Number <4 #4

Closed
DruideBizeps opened this issue Oct 21, 2020 · 2 comments · Fixed by #5
Closed

No error when inserting a Version Number <4 #4

DruideBizeps opened this issue Oct 21, 2020 · 2 comments · Fixed by #5
Assignees
@DudeNr33
Labels
bug Something isn't working

Comments

@DruideBizeps
Copy link

When a version number with less than 4 point separated digits is used no error is reported, but the pyinstaller fails because of that.
Proposal:
Either warn the user,
or
fill up the missing places with 0(s)
@DudeNr33 DudeNr33 self-assigned this Oct 22, 2020
@DudeNr33 DudeNr33 added the bug Something isn't working label Oct 22, 2020
@DudeNr33
Copy link
Owner

Thank you for reporting this.
I agree, pyinstaller-versionfile should try to only create output which can be interpreted by PyInstaller.
Since version numbers with less than 4 places are very common I will go for your second suggestion and fill it up with zeros.

DudeNr33 added a commit that referenced this issue Oct 22, 2020
@DudeNr33
Fix issue #4
9964f0f
DudeNr33 added a commit that referenced this issue Oct 22, 2020
@DudeNr33
Merge pull request #5 from DudeNr33/develop
e27c109 
Merge bugfix for issue #4
@DudeNr33
Copy link
Owner

Fixed with v1.0.2.

@DudeNr33 DudeNr33 linked a pull request Oct 24, 2020 that will close this issue
Merge bugfix for issue #4 #5
Merged
@DudeNr33 DudeNr33 mentioned this issue Apr 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DudeNr33 DudeNr33

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge bugfix for issue #4 DudeNr33/pyinstaller-versionfile
2 participants
@DudeNr33 @DruideBizeps