Update set_soils() to work with rSOILWAT2 before and after v6.0.0
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rSOILWAT2 v6.0.0 introduced custom soil water retention curves (via a new slot that contains parameters for each soil layers) - they must be kept up-to-date when soil information changes - rSOILWAT2 provides the method `swSoils_Layers()` to retrieve and replace soil information -- and to up-date soil water retention curve parameters - this commit also introduces a hack to fix evco and trco parameters which were not meeting requirements because the `set_soils()` function repeats the 3rd and 8th soil layer information; ideally, these parameters should be derived anew (replacing this hack)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rSOILWAT2 v6.0.0 introduced custom soil water retention curves (via a new slot that contains parameters for each soil layers) - they must be kept up-to-date when soil information changes
rSOILWAT2 provides the method
swSoils_Layers()to retrieve and replace soil information -- and to up-date soil water retention curve parametersthis also introduces a hack to fix evco and trco parameters which were not meeting requirements because the
set_soils()function repeats the 3rd and 8th soil layer information; ideally, these parameters should be derived anew (replacing this hack)