Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GoogleTest #430

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Update GoogleTest #430

merged 3 commits into from
Aug 8, 2024

Conversation

dschlaep
Copy link
Member

@dschlaep dschlaep commented Aug 8, 2024

dschlaep added 2 commits August 8, 2024 08:54
@dschlaep
Update GoogleTest to v1.15.2
cc93519 
- Update to C++17 for attribute "maybe_unused"

- close #427
@dschlaep
Fix signedness in alloc_netCDF_domain_vars()
fb90020 
- comparison of integer expressions of different signedness: 'unsigned int' and 'int' [-Werror=sign-compare]
@dschlaep dschlaep requested a review from N1ckP3rsl3y August 8, 2024 13:37
@dschlaep dschlaep linked an issue Aug 8, 2024 that may be closed by this pull request
Update tests to GoogleTest v1.15.2 #427
Closed
@codecov Codecov
Copy link

codecov bot commented Aug 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.33%. Comparing base (54abffe) to head (42dc670).

Additional details and impacted files 
@@                  Coverage Diff                  @@
##           release/devel_v8.1.0     #430   +/-   ##
=====================================================
  Coverage                 73.33%   73.33%           
=====================================================
  Files                        20       20           
  Lines                      6233     6233           
=====================================================
  Hits                       4571     4571           
  Misses                     1662     1662

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dschlaep dschlaep merged commit f8d6cd8 into release/devel_v8.1.0 Aug 8, 2024
12 checks passed
@dschlaep dschlaep deleted the update_GoogleTest branch August 8, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N1ckP3rsl3y N1ckP3rsl3y N1ckP3rsl3y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update tests to GoogleTest v1.15.2
2 participants
@dschlaep @N1ckP3rsl3y