Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify type of soil density inputs #323

Closed
wants to merge 1 commit into from
Closed

Specify type of soil density inputs #323

wants to merge 1 commit into from

Conversation

dschlaep
Copy link
Member

@dschlaep dschlaep commented Aug 2, 2022

  • new behavior: user specifies whether input soil density represents matric or bulk density; code then determines both matric and bulk density values from inputs
  • previous behavior: input soil density was treated as matric density and converted to bulk density

@dschlaep
Specify type of soil density inputs
ed6d0aa 
- close #280 (Soil density: input either for < 2 mm fraction or for whole soil)

- `SW_SITE` gains `type_soilDensityInput` to encode whether soil density inputs represent matric soil density or bulk soil density
-> user inputs change `siteparam.in`: new input for `type_soilDensityInput`

- `SW_LAYER_INFO` gains new `soilDensityInput` to store soil density inputs (inputs were previously stored as `soilMatric_density`)

- new `calculate_soilMatricDensity()` to calculate matric density from bulk density

- `SW_SIT_init_run()` now determines both matric soil density and bulk soil density from `soilDensityInput` depending on  `type_soilDensityInput`

- `set_soillayers()` now expects bulk density inputs as `bd` instead of matric density `matricd`

-> previous behavior: input soil density was treated as matric density and converted to bulk density (however, most of the time real word inputs represent bulk density)
@dschlaep dschlaep added this to the Release v7.0.0 milestone Aug 2, 2022
@dschlaep dschlaep self-assigned this Aug 2, 2022
@dschlaep
Copy link
Member Author

dschlaep commented Aug 2, 2022

this should be a PR into release/devel_v7.0.0!

@dschlaep dschlaep closed this Aug 2, 2022
@dschlaep dschlaep deleted the feature_soildensity_type branch August 3, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dschlaep dschlaep

Labels
None yet
Projects
None yet
Milestone
Release v7.0.0
Development

Successfully merging this pull request may close these issues.

Soil density: input either for < 2 mm fraction or for whole soil?
1 participant
@dschlaep