Bugfix 206 #209
Merged
Bugfix 206 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tain setups - address issue #206: ``` In file included from googletest/googletest/src/gtest-all.cc:42: googletest/googletest/src/gtest.cc:393:12: error: missing field 'owner_' initializer [-Werror,-Wmissing-field-initializers] GTEST_API_ GTEST_DEFINE_STATIC_MUTEX_(g_linked_ptr_mutex); ``` - this appears to be a problem described here google/googletest#1521 which remains unsolved as of today - another project on github addressed this issue temporarily (advancedtelematic/aktualizr#841) by checking out `googletest` one commit before this problem was introduced with commit google/googletest@87a4cdd, i.e, google/googletest@7888184
- addressing #206: both clang and gcc work (at least locally) * CXX=clang++ make clean test test_run * CXX=g++ make clean test test_run - don't overwrite standard flags such as CFLAGS, etc. - ignore errors when cleaning up (prefix commands with a hyphen) - ignore errors arising from deprecated warnings (as c code under clang++) --> remove once #208 is fixed - target `clean` is now a synonym of `cleaner` - first target is now `bin`, i.e., calling `make` will now compile the executable - updated `SW_Output_mock.c`
…codecov` - we had no updated code coverage for the last five months...
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
=========================================
Coverage ? 60.04%
=========================================
Files ? 20
Lines ? 3624
Branches ? 0
=========================================
Hits ? 2176
Misses ? 1448
Partials ? 0
Continue to review full report at Codecov.
|
- we test with both `gnu` and `llvm` (clang) compilers on travis by setting the build option `compiler` - this however only set the CC environmental variable; because we compile both with CC and CXX (for the unit tests), we need to set both
- previous commit (8db9fa4) didn't work: after the clang matrix expansion, the test build still uses g++ for CXX --> switch project to cpp
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clangcompiler worksgoogletestto specific commitmakefileto be ignored (instead of propagated to errors)