Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read daily weather before the simulations #311

Closed
dschlaep opened this issue Jun 17, 2022 · 0 comments
Closed

Read daily weather before the simulations #311

dschlaep opened this issue Jun 17, 2022 · 0 comments

Comments

@dschlaep
Copy link
Member

Historically, the simulation loop was obtaining daily weather values for one complete year at the start of each simulated year (SW_WTH_new_year()) and then at the start of each simulated day, _todays_weth() was providing the weather values for that day (either from an array, or if missing, from the weather generator) to the simulation.

Now, we prepare all daily weather for all years before the simulations:

  1. read_all_weather() reads values from files (or uses the weather generator; or, if rSOILWAT2, obtains values via memory from R) and fills in values of all_hist -- before the start of the simulation loop

    • Incorporate current functionality of _todays_weth() in read_all_weather()
  2. SW_WTH_new_year() and _todays_weth() are no longer needed -> delete

  3. SW_WTH_new_day() will grab values out of all_hist (instead of calling _todays_weth())

@dschlaep dschlaep added this to the main development milestone Jun 17, 2022
dschlaep added a commit that referenced this issue Nov 30, 2022
- More detailed entries for developments towards issues #311 (daily weather), #317 (climate predictors), and #318 (estimate fractional cover of vegetation types from climate conditions)
dschlaep added a commit that referenced this issue Jun 9, 2023
Release v7.0.0

see https://github.com/DrylandEcology/SOILWAT2/milestone/13

- Read daily weather before the simulations enhancement (#311)
- Calculate climate variables before simulation loop (#317)
- Estimate vegetation cover from climate before simulation run (#318)
- Implement multiple soil water retention curves (#315)
- Soil density: input either for < 2 mm fraction or for whole soil? enhancement (#280)
- Re-organize repository with more sub-folders question (#89)
- Daily variables for atmospheric demand (#341)
- STEPWAT2 updated to work with this release (see DrylandEcology/STEPWAT2#535)
- rSOILWAT2 updated to work with this release (see DrylandEcology/rSOILWAT2#214)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants