Our clang-tidy setup requires >= v17

- "tools/run_tidy.sh" now checks clang-tidy version number and fails if < v17
- gha workflow "clang-tidy-check.yml" now runs on ubuntu-24.04 that should have clang v18

.github/workflows/clang-tidy-check.yml

@@ -1,5 +1,8 @@
 name: clang-tidy check
 
+# ubuntu-24.04 comes with clang v18 as default
+# ubuntu-latest as of 2024-Aug-01 points to ubuntu-22.04 with clang v14
+
 on:
   push:
     branches: [master, main, release/**]
@@ -9,13 +12,13 @@ on:
 jobs:
   formatting-check:
     name: Tidy Check
-    runs-on: ubuntu-latest
-      
+    runs-on: ubuntu-24.04
+
     steps:
     - name: Checkout repository and submodules
       uses: actions/checkout@v4
       with:
         submodules: recursive
-      
+
     - name: Run
       run: ./tools/run_tidy.sh

tools/run_tidy.sh

@@ -7,6 +7,16 @@ if ! command -v clang-tidy > /dev/null 2>&1; then
     exit 1
 fi
 
+# Verify that clang-tidy is at least v17
+ctv=$(clang-tidy --version | egrep -o "version [0-9]+.[0-9]+.[0-9]+")
+p1=$(echo "$ctv" | egrep -o "[0-9]+.[0-9]+.[0-9]+" | cut -d "." -f 1)
+
+if [ ! "$p1" -ge 17 ]; then
+    echo "We require clang-tidy version 17 or later but found" "${ctv}"
+    exit 1
+fi
+
+
 #-------------------------------------------------------------------------------
 process_clangtidy_results() {
     local status="$1"