Skip to content
This repository was archived by the owner on Aug 18, 2022. It is now read-only.

Allow leaf module to have the same name as top module #17

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

Drvi
Copy link
Owner

@Drvi Drvi commented Aug 15, 2022

Fixes #16

@Drvi Drvi force-pushed the td-leaf-and-topmost-module-names-clash-fix branch from b1ef40c to cdd589a Compare August 15, 2022 13:12
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #17 (3eeeb8a) into master (95c669d) will increase coverage by 0.09%.
The diff coverage is 90.90%.

❗ Current head 3eeeb8a differs from pull request most recent head d40129b. Consider uploading reports for the commit d40129b to get more accurate results

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   89.07%   89.16%   +0.09%     
==========================================
  Files          25       25              
  Lines        2754     2760       +6     
==========================================
+ Hits         2453     2461       +8     
+ Misses        301      299       -2     
Impacted Files Coverage Δ
src/ProtocolBuffers.jl 75.00% <ø> (ø)
src/precompile.jl 0.00% <0.00%> (ø)
src/codegen/modules.jl 88.75% <75.00%> (+0.80%) ⬆️
src/codegen/names.jl 100.00% <100.00%> (ø)
src/codegen/types.jl 97.80% <100.00%> (ø)
src/codegen/utils.jl 75.78% <100.00%> (+0.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Drvi Drvi merged commit 924b661 into master Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When the topmost and a leaf module share a name, we get an error.
2 participants