Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Removed features that are not minimal. #355

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

CreativeCodeCat
Copy link
Contributor

Type of change

  • Feature Request (user facing)

All Submissions

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you made a descriptive commit message with a short title (first line).
  • Have you performed a self-review of your code
  • Have you commented your code, particularly in hard-to-understand areas
  • My changes generate no new warnings or errors of any kind
  • You have done your changes in a separate branch.
  • Branch has descriptive name that start with either the bug/ feat/ or clean/ prefixes.

After these steps, you're ready to open a pull request.

  • Give a descriptive title to your PR.
  • Describe your changes in the area below.

Description of the changes in your PR

Fixes the following issue(s)

  1. Removed settings for calendar toggle
  2. Removed calendar permissions
  3. Removed calendar events displaying on home.

Test Device:

  • mLauncher version: 1.3.3
  • Device name: Pixel 7
  • Android version: 14
  • Other information: N/A

@CreativeCodeCat CreativeCodeCat changed the title Removed features that are not minimal [Feature] Removed features that are not minimal. Mar 9, 2024
@CreativeCodeCat CreativeCodeCat merged commit e105dad into main Mar 9, 2024
@CreativeCodeCat CreativeCodeCat deleted the Feature/Cleanup-Non-Minimal-Features branch March 9, 2024 17:12
@CreativeCodeCat CreativeCodeCat added the Type: Enhancement New feature or request label Mar 9, 2024
@szechp
Copy link

szechp commented Mar 20, 2024

Hey, it's a pitty this got removed, I wanted to suggest an alternative: what about one single widget? Right under the clock, this would give tons of options for users, while keeping it minimal.

@CreativeCodeCat
Copy link
Contributor Author

Hey, it's a pitty this got removed, I wanted to suggest an alternative: what about one single widget? Right under the clock, this would give tons of options for users, while keeping it minimal.

@szechp maybe we can have a look into adding something like that in the feature but for now wit that being buggy and only using the built in calendar people wanted it to use any calendar that is installed which would be more tricky so i just wanted rid of it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants