Changes for easier Linux packaging #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. I've been eyeing flatpak (though mostly for my rewrite to Rust) so that would be nice as well |
|
ah okay! yeah submitting to flathub would happen in a separate repo, I can finish that today tho |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #645, I wanted to make things easier for packaging the application for things like flatpak.
make install.XDG_DATA_DIRSfor assets. This is usually set by the distro or packaging system and defines where a package's assets should be located.If you're okay with merging these changes, I do have a flatpak manifest that is ready to go if you're interested in submitting to flathub!
Let me know if you have any questions, or would like any changes. Thanks!